Orders and fulfillment reports display price currency

makeitgreat
Tags: #<Tag:0x00007fb042221290>

#1

What is the need / problem ?

This stems from https://github.com/openfoodfoundation/openfoodnetwork/issues/3510

Orders and fulfillment report doesn’t display price currency and that makes it hard to read. It would be much easier to spot and understand the price columns if they had the currency next to them, otherwise, it’s not easy to get what those decimal numbers are about at a first glance.

Who does it impact ?

Enterprise admins.

What is the current impact of the problem ?

  • A poor admin experience when it comes to checking reports
  • Confidence on the admin when ensuring prices are correct

What is the benefit of focusing on this ?

  • Improved experience for admins
  • A sense of polished product and attention to details that admins will percieve

Potential solutions that will solve the problem ?

What comes is the tech solution I posted in https://github.com/openfoodfoundation/openfoodnetwork/issues/3510. To my understanding, this is something that can be done very quickly and doesn’t require too much upfront thinking. So, fixing current reports implementation is a very valid potential solution.

It turns out that app/views/spree/admin/reports/_table.html.haml prints the cell values straight from lib/open_food_network/orders_and_fulfillments_report.rb and no currency is taken into account. The value we pass to the view should have it appended, possibly by extracting a presenter object.

Selection of a feature candidate

[value x ease matric if needed]

T-shirt size of our selected feature candidate

Metrics to measure if need is satisfied after feature is implemented

Feature owners

Epic/projet where you can follow implementation


Connected wishlist and discovery discussions*

[list precedent discussions]


#2

I think this is clear enough to go straight to Voting :+1:


#3

I swear there is no bribery on that comment above. @sigmundpetersen expressed his own opinion :joy: