Delivery Circle meeting - February 14th 💘

jibees · February 14, 2023, 10:12am

Thanks @dcook for facilitating the meeting!

Board

@dcook

Webhook on order cycle open is on progress. Pretty though, and taking longer than expected.
Bump sidekick
Upgrading nodejs on managed servers (very old version used): we need to find a good solution upgrading node on those servers (and links with Ubuntu) ; we probably should use nodenv.
Raise an issue and we probably need to upgrade Ubuntu on instanced server. Maybe having a production docker ready is a good way (easier way) to improve this. Should we prioritize Upgrade to Ubuntu 18.04 LTS Bionic Beaver · Issue #157 · openfoodfoundation/ofn-install · GitHub ? But we do have the Rails7 and replace webpacker by the rails asset manager should be on top on tech debt column.

@maikel

Made some progress on DFC. I can use the Connector to generate JSON. I will need another day to finish that off and then we have a pull request to test once the prototype works again.
We had a good vouchers kick-off and Gaetan and I can start work within the next days. There are still some tax implications to discuss (Kirsten and Lynne will talk to an accountant).
I ticked some small tech-debt off.
Background-reports are in review.

@Gaetan

Will start working on vouchers very soon
Some backoffice uplift, one PR in review
Some discussion around StimulusJS on https://github.com/openfoodfoundation/openfoodnetwork/pull/10351

@jibees

Work on splitcheckout errors improvments SplitCheckout: improve error messages in flash banner to improve user experience by jibees · Pull Request #10428 · openfoodfoundation/openfoodnetwork · GitHub Almost ready.
Will start working on column selector re-design Create a columns selector component and remove the angular directive one by jibees · Pull Request #10143 · openfoodfoundation/openfoodnetwork · GitHub

@abdellani

Blocked on S3 one: https://github.com/openfoodfoundation/openfoodnetwork/pull/10135 What to do next? Someone needs to look deeply at the code. Maybe some pairing with @dcook ? @maikel will probably join also. (what a team!) Question raised by @filipefurtado : When do we want to update an order? This PR should not solve everything.

Discussion

Legal invoices

github.com/openfoodfoundation/wishlist

Legally compliant invoices

opened 11:31AM - 03 Feb 23 UTC

RachL

Epic

## What is the problem we are solving Currently invoices are generated "on dem…and" any generation just takes the most up-to-date value of the order. This is illegal: if an invoice was previously generated for an order and this order has changed, the invoice should be cancelled and a new invoice should be issued. I**f the order was not changed, then no new invoice should be generated**. If the order was paid when the first invoice was generated, two invoices should be created: one credit invoice and one new invoice. The new invoice is the invoice we would be creating now Invoices should have incremental numbers **by hub**. example: - JB orders at Filipe shop - Filipe generates an invoice to JB. Let's say this invoice is number 30 - Rachel orders at Filipe. when Filipe invoice Rachel, this invoice has number 31 - Let's say JB now ask Filipe to make changes on the order (add a product for example) - Filipe generates a new order for JB: this invoice has now the number 32 if the order was unpaid. If JB had already paid, two invoices are generated: one credit invoice with number 32 (with a mention that this credits invoice 30) and one new invoice with number 33. Ideally, we would allow each hub to set an invoice prefix (in business details for example) and the number at which their invoices should start. From there, all invoices from this enterprise have the same prefix and a sequential number. ## Link to the "Product Development - Backlog" item in Discourse https://community.openfoodnetwork.org/t/trace-order-amendments-through-invoice-lines-and-generate-legally-compliant-invoices/1502/44

Is the main question the following: What should make an invoice be re-calculated (related to the blocked s3 above)?
Maybe worth a big workshop to work together synchronously on that.
Should we introduce a button available for distributor “Generate an new invoice”; when do an order could have an invoice?
Have a data model stored in a way, and compare it?
Many questions raised.

Rachel · February 14, 2023, 1:51pm

Thanks for the notes

What should make an invoice be re-calculated (related to the blocked s3 above)?

The list is in the issue - refunds are missing and I need to add them - As an enterprise admin, I can print and send invoices on the edit order page · Issue #10725 · openfoodfoundation/openfoodnetwork · GitHub

Maybe worth a big workshop to work together synchronously on that.

Errr franckly I would like to avoid that. It’s a nightmare to set up. It also makes me wonder about our processes. Why do we need everyone on this particular piece when we don’t do it for others, e.g. vouchers?

Should we introduce a button available for distributor “Generate an new invoice”; when do an order could have an invoice?

An order has an invoice if an admin decide to generate an invoice. The button was designed in the issue: As an enterprise admin, I can print and send invoices on the edit order page · Issue #10725 · openfoodfoundation/openfoodnetwork · GitHub

Many questions raised.

Can everyone list them here or in the slack channel?