Discussion: managing instance-specific variables
Maikel raised that to add instance-specific settings for new features requires updates in two repos. (The settings go in host_vars in ofn-install, which means co-ordinating an extra PR, and running an ansible provisioning step).
This was raised in the context of setting keycloak servers, but applies to a few other existing settings too (currency, available locales, etc). Note that this would not apply to secrets, they still need to be handled separately.
Suggestion: store these settings within the openfoodnetwork codebase instead. It can be in a yaml file under config/
.
Benefits:
- the settings are closer to the code that uses them
- easy to see in one place what settings have been used
- less indirection, no need for host_vars being deployed with ansible to a .env file.
@chahmedejaz update
- PR awaiting code review
- Next: add customer email and phone to email report
@maikel
- PoC for DFC permissions working but waiting on more updates from DFC
- Got CI working for ofn-install and ubuntu 20 and 24, yay!
- Will pick up David’s PR for DFC Orders endpoint.
@dcook
I don’t currently have enough hours in the week for OFN dev, so will only be doing code review, releases and help on Slack where needed. I won’t attend delivery circle every week, perhaps fortnightly for the time being.