Discussion topics
i) Upgrade Ubuntu version on Production servers
@dcook @maikel
Some thoughts/limitations: servers are a bit unique on different versions of postgresql; usually done overnight, for the respective timezones. We have more servers than ever - around 10 servers to maintain. An issue/plan will be created for next meeting.
@abdellani mentions there were issues with Ubuntu 22.04, so might be safer to go for 20.04; @filipefurtado mentions we’ve opted to upgrade Github test-suite runners to 20.04 due to this issue ; Both options have LTS versions, so the plan could be to:
First step to upgrade staging servers - to v22.04 and re-evaluate compatibility again.
Also, we need to assure that upgrading to 20.04 helps unblocking the issue:
openfoodfoundation:master
← openfoodfoundation:dependabot/npm_and_yarn/jest-29.5.0
opened 09:57AM - 27 Mar 23 UTC
Bumps [jest](https://github.com/facebook/jest/tree/HEAD/packages/jest) from 27.5… .1 to 29.5.0.
\+ bumps node to latest LTS version (ie. 18.15.0)
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/releases">jest's releases</a>.</em></p>
<blockquote>
<h2>v29.5.0</h2>
<h2>Features</h2>
<ul>
<li><code>[jest-changed-files]</code> Support Sapling (<a href="https://redirect.github.com/facebook/jest/pull/13941">#13941</a>)</li>
<li><code>[jest-circus, @jest/cli, jest-config]</code> Add feature to randomize order of tests via CLI flag or through the config file(<a href="https://redirect.github.com/facebook/jest/pull/12922">#12922</a>)</li>
<li><code>[jest-cli, jest-config, @jest/core, jest-haste-map, @jest/reporters, jest-runner, jest-runtime, @jest/types]</code> Add <code>workerThreads</code> configuration option to allow using <a href="https://nodejs.org/dist/latest/docs/api/worker_threads.html">worker threads</a> for parallelization (<a href="https://redirect.github.com/facebook/jest/pull/13939">#13939</a>)</li>
<li><code>[jest-cli]</code> Export <code>yargsOptions</code> (<a href="https://redirect.github.com/facebook/jest/pull/13970">#13970</a>)</li>
<li><code>[jest-config]</code> Add <code>openHandlesTimeout</code> option to configure possible open handles warning. (<a href="https://redirect.github.com/facebook/jest/pull/13875">#13875</a>)</li>
<li><code>[@jest/create-cache-key-function]</code> Allow passing <code>length</code> argument to <code>createCacheKey()</code> function and set its default value to <code>16</code> on Windows (<a href="https://redirect.github.com/facebook/jest/pull/13827">#13827</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError">AggregateError</a> (<a href="https://redirect.github.com/facebook/jest/pull/13946">#13946</a> & <a href="https://redirect.github.com/facebook/jest/pull/13947">#13947</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause">Error causes</a> in <code>test</code> and <code>it</code> (<a href="https://redirect.github.com/facebook/jest/pull/13935">#13935</a> & <a href="https://redirect.github.com/facebook/jest/pull/13966">#13966</a>)</li>
<li><code>[jest-reporters]</code> Add <code>summaryThreshold</code> option to summary reporter to allow overriding the internal threshold that is used to print the summary of all failed tests when the number of test suites surpasses it (<a href="https://redirect.github.com/facebook/jest/pull/13895">#13895</a>)</li>
<li><code>[jest-runtime]</code> Expose <code>@sinonjs/fake-timers</code> async APIs functions <code>advanceTimersByTimeAsync(msToRun)</code> (<code>tickAsync(msToRun)</code>), <code>advanceTimersToNextTimerAsync(steps)</code> (<code>nextAsync</code>), <code>runAllTimersAsync</code> (<code>runAllAsync</code>), and <code>runOnlyPendingTimersAsync</code> (<code>runToLastAsync</code>) (<a href="https://redirect.github.com/facebook/jest/pull/13981">#13981</a>)</li>
<li><code>[jest-runtime, @jest/transform]</code> Allow V8 coverage provider to collect coverage from files which were not loaded explicitly (<a href="https://redirect.github.com/facebook/jest/pull/13974">#13974</a>)</li>
<li><code>[jest-snapshot]</code> Add support to <code>cts</code> and <code>mts</code> TypeScript files to inline snapshots (<a href="https://redirect.github.com/facebook/jest/pull/13975">#13975</a>)</li>
<li><code>[jest-worker]</code> Add <code>start</code> method to worker farms (<a href="https://redirect.github.com/facebook/jest/pull/13937">#13937</a>)</li>
<li><code>[jest-worker]</code> Support passing a URL as path to worker (<a href="https://redirect.github.com/facebook/jest/pull/13982">#13982</a>)</li>
</ul>
<h2>Fixes</h2>
<ul>
<li><code>[babel-plugin-jest-hoist]</code> Fix unwanted hoisting of nested <code>jest</code> usages (<a href="https://redirect.github.com/facebook/jest/pull/13952">#13952</a>)</li>
<li><code>[jest-circus]</code> Send test case results for <code>todo</code> tests (<a href="https://redirect.github.com/facebook/jest/pull/13915">#13915</a>)</li>
<li><code>[jest-circus]</code> Update message printed on test timeout (<a href="https://redirect.github.com/facebook/jest/pull/13830">#13830</a>)</li>
<li><code>[jest-circus]</code> Avoid creating the word "testfalse" when <code>takesDoneCallback</code> is <code>false</code> in the message printed on test timeout AND updated timeouts test (<a href="https://redirect.github.com/facebook/jest/pull/13954">#13954</a>)</li>
<li><code>[jest-environment-jsdom]</code> Stop setting <code>document</code> to <code>null</code> on teardown (<a href="https://redirect.github.com/facebook/jest/pull/13972">#13972</a>)</li>
<li><code>[@jest/expect-utils]</code> Update <code>toStrictEqual()</code> to be able to check <code>jest.fn().mock.calls</code> (<a href="https://redirect.github.com/facebook/jest/pull/13960">#13960</a>)</li>
<li><code>[@jest/test-result]</code> Allow <code>TestResultsProcessor</code> type to return a Promise (<a href="https://redirect.github.com/facebook/jest/pull/13950">#13950</a>)</li>
</ul>
<h2>Chore & Maintenance</h2>
<ul>
<li><code>[jest-snapshot]</code> Remove dependency on <code>jest-haste-map</code> (<a href="https://redirect.github.com/facebook/jest/pull/13977">#13977</a>)</li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/frosas"><code>@frosas</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13932">facebook/jest#13932</a></li>
<li><a href="https://github.com/akshitsinha"><code>@akshitsinha</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13915">facebook/jest#13915</a></li>
<li><a href="https://github.com/trajano"><code>@trajano</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13827">facebook/jest#13827</a></li>
<li><a href="https://github.com/DercilioFontes"><code>@DercilioFontes</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13954">facebook/jest#13954</a></li>
<li><a href="https://github.com/jsnajdr"><code>@jsnajdr</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13952">facebook/jest#13952</a></li>
<li><a href="https://github.com/SteveFlames"><code>@SteveFlames</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13895">facebook/jest#13895</a></li>
<li><a href="https://github.com/willc001"><code>@willc001</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13970">facebook/jest#13970</a></li>
<li><a href="https://github.com/benjaminhobbs"><code>@benjaminhobbs</code></a> made their first contribution in <a href="https://redirect.github.com/facebook/jest/pull/13901">facebook/jest#13901</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/facebook/jest/compare/v29.4.3...v29.5.0">https://github.com/facebook/jest/compare/v29.4.3...v29.5.0</a></p>
<h2>v29.4.3</h2>
<h2>Features</h2>
<ul>
<li><code>[expect]</code> Update <code>toThrow()</code> to be able to use error <code>cause</code>s (<a href="https://redirect.github.com/facebook/jest/pull/13606">#13606</a>)</li>
<li><code>[jest-core]</code> allow to use <code>workerIdleMemoryLimit</code> with only 1 worker or <code>runInBand</code> option (<a href="https://redirect.github.com/facebook/jest/pull/13846">#13846</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause">error <code>cause</code>s</a> (<a href="https://redirect.github.com/facebook/jest/pull/13868">#13868</a> & <a href="https://redirect.github.com/facebook/jest/pull/13912">#13912</a>)</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/facebook/jest/blob/main/CHANGELOG.md">jest's changelog</a>.</em></p>
<blockquote>
<h2>29.5.0</h2>
<h3>Features</h3>
<ul>
<li><code>[jest-changed-files]</code> Support Sapling (<a href="https://redirect.github.com/facebook/jest/pull/13941">#13941</a>)</li>
<li><code>[jest-circus, @jest/cli, jest-config]</code> Add feature to randomize order of tests via CLI flag or through the config file(<a href="https://redirect.github.com/facebook/jest/pull/12922">#12922</a>)</li>
<li><code>[jest-cli, jest-config, @jest/core, jest-haste-map, @jest/reporters, jest-runner, jest-runtime, @jest/types]</code> Add <code>workerThreads</code> configuration option to allow using <a href="https://nodejs.org/dist/latest/docs/api/worker_threads.html">worker threads</a> for parallelization (<a href="https://redirect.github.com/facebook/jest/pull/13939">#13939</a>)</li>
<li><code>[jest-cli]</code> Export <code>yargsOptions</code> (<a href="https://redirect.github.com/facebook/jest/pull/13970">#13970</a>)</li>
<li><code>[jest-config]</code> Add <code>openHandlesTimeout</code> option to configure possible open handles warning. (<a href="https://redirect.github.com/facebook/jest/pull/13875">#13875</a>)</li>
<li><code>[@jest/create-cache-key-function]</code> Allow passing <code>length</code> argument to <code>createCacheKey()</code> function and set its default value to <code>16</code> on Windows (<a href="https://redirect.github.com/facebook/jest/pull/13827">#13827</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError">AggregateError</a> (<a href="https://redirect.github.com/facebook/jest/pull/13946">#13946</a> & <a href="https://redirect.github.com/facebook/jest/pull/13947">#13947</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause">Error causes</a> in <code>test</code> and <code>it</code> (<a href="https://redirect.github.com/facebook/jest/pull/13935">#13935</a> & <a href="https://redirect.github.com/facebook/jest/pull/13966">#13966</a>)</li>
<li><code>[jest-reporters]</code> Add <code>summaryThreshold</code> option to summary reporter to allow overriding the internal threshold that is used to print the summary of all failed tests when the number of test suites surpasses it (<a href="https://redirect.github.com/facebook/jest/pull/13895">#13895</a>)</li>
<li><code>[jest-runtime]</code> Expose <code>@sinonjs/fake-timers</code> async APIs functions <code>advanceTimersByTimeAsync(msToRun)</code> (<code>tickAsync(msToRun)</code>), <code>advanceTimersToNextTimerAsync(steps)</code> (<code>nextAsync</code>), <code>runAllTimersAsync</code> (<code>runAllAsync</code>), and <code>runOnlyPendingTimersAsync</code> (<code>runToLastAsync</code>) (<a href="https://redirect.github.com/facebook/jest/pull/13981">#13981</a>)</li>
<li><code>[jest-runtime, @jest/transform]</code> Allow V8 coverage provider to collect coverage from files which were not loaded explicitly (<a href="https://redirect.github.com/facebook/jest/pull/13974">#13974</a>)</li>
<li><code>[jest-snapshot]</code> Add support to <code>cts</code> and <code>mts</code> TypeScript files to inline snapshots (<a href="https://redirect.github.com/facebook/jest/pull/13975">#13975</a>)</li>
<li><code>[jest-worker]</code> Add <code>start</code> method to worker farms (<a href="https://redirect.github.com/facebook/jest/pull/13937">#13937</a>)</li>
<li><code>[jest-worker]</code> Support passing a URL as path to worker (<a href="https://redirect.github.com/facebook/jest/pull/13982">#13982</a>)</li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[babel-plugin-jest-hoist]</code> Fix unwanted hoisting of nested <code>jest</code> usages (<a href="https://redirect.github.com/facebook/jest/pull/13952">#13952</a>)</li>
<li><code>[jest-circus]</code> Send test case results for <code>todo</code> tests (<a href="https://redirect.github.com/facebook/jest/pull/13915">#13915</a>)</li>
<li><code>[jest-circus]</code> Update message printed on test timeout (<a href="https://redirect.github.com/facebook/jest/pull/13830">#13830</a>)</li>
<li><code>[jest-circus]</code> Avoid creating the word "testfalse" when <code>takesDoneCallback</code> is <code>false</code> in the message printed on test timeout AND updated timeouts test (<a href="https://redirect.github.com/facebook/jest/pull/13954">#13954</a>)</li>
<li><code>[jest-environment-jsdom]</code> Stop setting <code>document</code> to <code>null</code> on teardown (<a href="https://redirect.github.com/facebook/jest/pull/13972">#13972</a>)</li>
<li><code>[@jest/expect-utils]</code> Update <code>toStrictEqual()</code> to be able to check <code>jest.fn().mock.calls</code> (<a href="https://redirect.github.com/facebook/jest/pull/13960">#13960</a>)</li>
<li><code>[@jest/test-result]</code> Allow <code>TestResultsProcessor</code> type to return a Promise (<a href="https://redirect.github.com/facebook/jest/pull/13950">#13950</a>)</li>
</ul>
<h3>Chore & Maintenance</h3>
<ul>
<li><code>[jest-snapshot]</code> Remove dependency on <code>jest-haste-map</code> (<a href="https://redirect.github.com/facebook/jest/pull/13977">#13977</a>)</li>
</ul>
<h2>29.4.3</h2>
<h3>Features</h3>
<ul>
<li><code>[expect]</code> Update <code>toThrow()</code> to be able to use error <code>cause</code>s (<a href="https://redirect.github.com/facebook/jest/pull/13606">#13606</a>)</li>
<li><code>[jest-core]</code> allow to use <code>workerIdleMemoryLimit</code> with only 1 worker or <code>runInBand</code> option (<a href="https://redirect.github.com/facebook/jest/pull/13846">#13846</a>)</li>
<li><code>[jest-message-util]</code> Add support for <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause">error <code>cause</code>s</a> (<a href="https://redirect.github.com/facebook/jest/pull/13868">#13868</a> & <a href="https://redirect.github.com/facebook/jest/pull/13912">#13912</a>)</li>
<li><code>[jest-runtime]</code> Revert <code>import assertions</code> for JSON modules as it's been relegated to Stage 2 (<a href="https://redirect.github.com/facebook/jest/pull/13911">#13911</a>)</li>
</ul>
<h3>Fixes</h3>
<ul>
<li><code>[@jest/expect-utils]</code> <code>subsetEquality</code> should consider also an object's inherited string keys (<a href="https://redirect.github.com/facebook/jest/pull/13824">#13824</a>)</li>
<li><code>[jest-mock]</code> Clear mock state when <code>jest.restoreAllMocks()</code> is called (<a href="https://redirect.github.com/facebook/jest/pull/13867">#13867</a>)</li>
<li><code>[jest-mock]</code> Prevent <code>mockImplementationOnce</code> and <code>mockReturnValueOnce</code> bleeding into <code>withImplementation</code> (<a href="https://redirect.github.com/facebook/jest/pull/13888">#13888</a>)</li>
<li><code>[jest-mock]</code> Do not restore mocks when <code>jest.resetAllMocks()</code> is called (<a href="https://redirect.github.com/facebook/jest/pull/13866">#13866</a>)</li>
</ul>
<h2>29.4.2</h2>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/facebook/jest/commit/39f3beda6b396665bebffab94e8d7c45be30454c"><code>39f3bed</code></a> v29.5.0</li>
<li><a href="https://github.com/facebook/jest/commit/a49c88610e49a3242576160740a32a2fe11161e1"><code>a49c886</code></a> v29.4.3</li>
<li><a href="https://github.com/facebook/jest/commit/6d2632adae0f0fa1fe116d3b475fd9783d0de1b5"><code>6d2632a</code></a> Update copyrights with Meta Platforms, restore original license in Jasmine fo...</li>
<li><a href="https://github.com/facebook/jest/commit/f0fc92e8443f09546c7ec0472bf9bce44fe5898f"><code>f0fc92e</code></a> v29.4.2</li>
<li><a href="https://github.com/facebook/jest/commit/bc7b20c9d4f6c399477b5a2b955dc0e1b736cd9b"><code>bc7b20c</code></a> chore: make sure to exclude .eslintcache from published module (<a href="https://github.com/facebook/jest/tree/HEAD/packages/jest/issues/13832">#13832</a>)</li>
<li><a href="https://github.com/facebook/jest/commit/bc84c8a15649aaaefdd624dc83824518c17467ed"><code>bc84c8a</code></a> v29.4.1</li>
<li><a href="https://github.com/facebook/jest/commit/4bc0e8acaf990e6618a7bed1dca67760c20bb12a"><code>4bc0e8a</code></a> v29.4.0</li>
<li><a href="https://github.com/facebook/jest/commit/6e5b1d60a1214e792b5229993b5475445e9c1a6e"><code>6e5b1d6</code></a> chore: update typescript (<a href="https://github.com/facebook/jest/tree/HEAD/packages/jest/issues/13616">#13616</a>)</li>
<li><a href="https://github.com/facebook/jest/commit/05deb8393c4ad71e19be2567b704dfd3a2ab5fc9"><code>05deb83</code></a> v29.3.1</li>
<li><a href="https://github.com/facebook/jest/commit/84b8de987b33e2da20dc833aeb65f23d72a673cd"><code>84b8de9</code></a> v29.3.0</li>
<li>Additional commits viewable in <a href="https://github.com/facebook/jest/commits/v29.5.0/packages/jest">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
ii) N8N maintenance discussion
Postponed, we ran out of time
The pipe
@Gaetan
Progressed with vouchers, waiting for feedback to move # 10587
@jibees
Some issues in dev to tackle:
Blocked on webpack #10631
Started working on the new recommended asset management on Rails (not so easy);
Bump node is blocked by upgrading servers
Opened PR to set split_checkout feature to be on by default - advice welcome
White label is on its way #10586
Finished display producers name (added a modal ) #10119
@filipefurtado
Analytics some progress - but slow. Debugging Matomo filters/goals in production.
Stripe coverage should be improved - getting back to this task. Will pair up with @abdellani on it
@abdellani
Progress on invoices: Implemented algorithm to compare invoices #10532 - after the review more tests need to be added. Should we implement a feature toggle? Brief discussion: it’s great to be able to iterate.
We can add the data migration, and keep the UI changes behind the toggle. To start with one invoice only, created in the background. This approach should work because the reports are generated from the UI.
Easier to have only template… Would need tests update.
Bug fix for customer reports (repeating names)
#10601
Enterprise fee w tax report - #10323 ; over to @dcook
Can we merge this as is - provided we test it on staging, that it does not bring down the server.
@lin_d_hop mentions: we currently don’t have a acceptance criteria on reports performance. Reports were designed a while a go, requirements may have changed, as there are other integration possibilities now in place
@dcook
Working on #10329
And Tax Report - #10323
Working as JS bundling Webpacker with @jibees
Move on to server upgrading with @maikel
Maybe up for tackling some BUU soon? @Mario and @rachel have updated the respective column in the meantime
@maikel
Worked on backround reports - PR #10644 updated, so display a download link up next
Upcoming PR: to send a download link
Notification from Maxime - so, DFC work/product import can be
Plenty of code review looking ahead
@Rachel
Enable feature toggle by #10658 - the team needs to keep this one in mind as it unblocks white label and vouchers.