What is the need / problem
To agree an enforce a code style guide also for our tests, which are still using the very old RSpec
should syntax. Chances are that this syntax won’t work in upcoming versions of RSpec.
Who does it impact
What is the current impact of this problem
We waste time and energy review the syntax used in a PR when this better done by machines. We would be better off focusing on architecture and implementation.
Using this old syntax may stop us from upgrading RSpec in the future.
What is the benefit in focusing on this
All new tests will be written in the RSpec
expect syntax without any devs having to review it and without having to worry about it for future upgrades.