Delivery Circle Meeting - November 15th

Delivery notes
Welcoming Mohamed! :heart_eyes:

Dev pipe:

OFN DFC Products
#9170
Done by Mikael before holidays; Rachel did a demo without fully testing, can she move it to testing? Not yet because Mikael said there might be only few lines of code to add

#9859
Performance issues
Mikael worked on some improvements: image loading on shop + loading on countries ā†’ it was deployed this morning

It looks like thereā€™s no performance issue in UK anymore (nothing in notifications channel).

FR : JB restarted the server this weekend

David can reproduce a memory leak by running the Order Cycle report which cause memory usage to grow each time it is run. It will be ok to restart PUMA everytime. He shared a graceful way of restarting that has a minimum impact on performance. Having some Cron tasks to restart PUMA once a day seems a good idea, especially during the night in FR.

David:

  • N8N user having db access: it seems we need to run a ??? task. Another person needs it to have some metrics working on N8N.

JB:

  • has worked a lot on flaky specs
  • His bigger task will be to move forward on UI uplift (8996) with Mikael. This consists in changing back office product page + colors on every page.

Mohamed

  • yesterday when starting his local project, was not able to checkout, he had the error ā€œNo valid order found for the checkout processingā€. He had to remove the db and create a new one. Lynne: it might be due to the fact that an order cycle was closed, and this might not be well handled in dev environment.
  • Producer and product tax status: new columns added to the reports for the taxes. Wondering which tests to do: unit test only or system request test? Lynne: only unit tests.

Filipe

  • Optimize the time build time for it to be more efficient, 9895 (knapsack); Long process, it has raised a lot of issues. But now itā€™s ok.
  • Working a bit on analytics, tests on Matomo, needs feedback to scope it
  • He noticed that at some points Matomo stopped tracking page views. It appears that itā€™s for Australia, Germany and US that servers are down. Rachel will look at it.
  • Hungary is beginning to use Matomo too (contact: Robert).

There was an issue raised by Amida this morning: ā€œa problem case where multiple customers, upon going to checkout, find another customerā€™s name and shipping address prefilled in the ā€˜Your detailsā€™ section of the checkoutā€
Only JB and David can revert
Mikael worked on country and address json, thatā€™s the only thing that looks could be linked to
If itā€™s related to address caching, would it appear on staging? Yes.
If itā€™s linked to caching, you might have to rerun the cache. Is it possible to trigger a cache run?
The team is investigatingā€¦

4 Likes

Do you teach online for making food?